tomscut commented on a change in pull request #3063:
URL: https://github.com/apache/hadoop/pull/3063#discussion_r780055220
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
##########
@@ -4909,6 +4932,75 @@ public long getLastRedundancyMonitorTS() {
return lastRedundancyCycleTS.get();
}
+ /**
+ * Periodically deletes the marked block.
+ */
+ private class MarkedDeleteBlockScrubber implements Runnable {
+ private Iterator<BlockInfo> toDeleteIterator = null;
+ private boolean isSleep;
+
+ private void remove(long time) {
+ if (checkToDeleteIterator()) {
+ namesystem.writeLock();
+ try {
+ while (toDeleteIterator.hasNext()) {
+ removeBlock(toDeleteIterator.next());
+ if (Time.monotonicNow() - time > deleteBlockLockTimeMs) {
+ isSleep = true;
+ break;
+ }
+ }
+ } finally {
+ namesystem.writeUnlock();
+ }
+ }
+ }
+
+ private boolean checkToDeleteIterator() {
+ return toDeleteIterator != null && toDeleteIterator.hasNext();
+ }
+
+ @Override
+ public void run() {
+ LOG.info("Start MarkedDeleteBlockScrubber thread");
+ while (namesystem.isRunning() &&
+ !Thread.currentThread().isInterrupted()) {
+ if (!markedDeleteQueue.isEmpty() || checkToDeleteIterator()) {
+ try {
+ NameNodeMetrics metrics = NameNode.getNameNodeMetrics();
+ metrics.setDeleteBlocksQueued(markedDeleteQueue.size());
+ isSleep = false;
+ long startTime = Time.monotonicNow();
+ remove(startTime);
+ while (!isSleep && !markedDeleteQueue.isEmpty() &&
+ !Thread.currentThread().isInterrupted()) {
+ List<BlockInfo> markedDeleteList = markedDeleteQueue.poll();
+ if (markedDeleteList != null) {
+ toDeleteIterator = markedDeleteList.listIterator();
+ }
+ remove(startTime);
+ }
+ } catch (Exception e){
+ LOG.warn("MarkedDeleteBlockScrubber encountered an exception" +
+ " during the block deletion process, " +
+ " the deletion of the block will retry in {} millisecond.",
+ deleteBlockUnlockIntervalTimeMs, e);
+ }
+ }
+ if (isSleep) {
Review comment:
At present, there are warn logs whose lock holding exceeds the
threshold. The same logs are generated here. Can we change the log level to
DEBUG?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
