Kimahriman commented on a change in pull request #3781:
URL: https://github.com/apache/hadoop/pull/3781#discussion_r780249433
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java
##########
@@ -742,7 +742,8 @@ private void checkLimit(ContainerId containerId, String pId,
ProcessTreeInfo ptInfo,
long currentVmemUsage,
long currentPmemUsage) {
- if (strictMemoryEnforcement && !elasticMemoryEnforcement) {
+ if ((strictMemoryEnforcement && !elasticMemoryEnforcement) ||
+ (!strictMemoryEnforcement && elasticMemoryEnforcement)) {
Review comment:
What's the use case of `strictMemoryEnforcement &&
elasticMemoryEnforcement` not matching this condition (and thus continuing with
the checkLimit). Should this condition just be `strictMemoryEnforcement ||
elasticMemoryEnforcement`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
