steveloughran commented on a change in pull request #3865:
URL: https://github.com/apache/hadoop/pull/3865#discussion_r780814295



##########
File path: 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
##########
@@ -2485,7 +2485,7 @@ private CredentialEntry 
getCredentialEntry(CredentialProvider provider,
    * @param name
    * @return clear text password or null
    */
-  protected char[] getPasswordFromConfig(String name) {
+  public char[] getPasswordFromConfig(String name) {

Review comment:
       aah. filesytems are meant to undeclare themselves as a source of 
credentials to avoid this...was this secrets for an fs/object store you were 
trying to retrieve?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to