luoge457 commented on a change in pull request #3781:
URL: https://github.com/apache/hadoop/pull/3781#discussion_r780861302
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java
##########
@@ -742,7 +742,8 @@ private void checkLimit(ContainerId containerId, String pId,
ProcessTreeInfo ptInfo,
long currentVmemUsage,
long currentPmemUsage) {
- if (strictMemoryEnforcement && !elasticMemoryEnforcement) {
+ if ((strictMemoryEnforcement && !elasticMemoryEnforcement) ||
+ (!strictMemoryEnforcement && elasticMemoryEnforcement)) {
Review comment:
thanks for your review, according to the checkLimit notes,
strictMemoryEnforcement && elasticMemoryEnforcement condition should fall back
to the polling-based mechanism.
`
// When cgroup-based strict memory enforcement is used alone without
// elastic memory control, the oom-kill would take care of it.
// However, when elastic memory control is also enabled, the oom
killer
// would be disabled at the root yarn container cgroup level (all
child
// cgroups would inherit that setting). Hence, we fall back to the
// polling-based mechanism.
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
