[
https://issues.apache.org/jira/browse/HADOOP-17409?focusedWorklogId=707135&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-707135
]
ASF GitHub Bot logged work on HADOOP-17409:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jan/22 21:28
Start Date: 11/Jan/22 21:28
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#3534:
URL: https://github.com/apache/hadoop/pull/3534#discussion_r782538228
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -4284,31 +3929,8 @@ private CopyResult copyFile(String srcKey, String
dstKey, long size,
String action = "copyFile(" + srcKey + ", " + dstKey + ")";
Invoker readInvoker = readContext.getReadInvoker();
- ObjectMetadata srcom;
- try {
- srcom = once(action, srcKey,
- () ->
- getObjectMetadata(srcKey, changeTracker, readInvoker, "copy"));
- } catch (FileNotFoundException e) {
- // if rename fails at this point it means that the expected file was not
- // found.
- // The cause is believed to always be one of
- // - File was deleted since LIST/S3Guard metastore.list.() knew of it.
- // - S3Guard is asking for a specific version and it's been removed by
- // lifecycle rules.
- // - there's a 404 cached in the S3 load balancers.
- LOG.debug("getObjectMetadata({}) failed to find an expected file",
- srcKey, e);
- // We create an exception, but the text depends on the S3Guard state
- String message = hasMetadataStore()
Review comment:
we always generated different messages when s3guard was on/off, didn;t
we?
now you only get the unguarded text
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 707135)
Time Spent: 7h 20m (was: 7h 10m)
> Remove S3Guard - no longer needed
> ---------------------------------
>
> Key: HADOOP-17409
> URL: https://issues.apache.org/jira/browse/HADOOP-17409
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/s3
> Affects Versions: 3.3.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
> With Consistent S3, S3Guard is superfluous.
> stop developing it and wean people off it as soon as they can.
> Then we can worry about what to do in the code. It has gradually insinuated
> its way through the layers, especially things like multi-object delete
> handling (see HADOOP-17244). Things would be a lot simpler without it
> This work is being done in the feature branch HADOOP-17409-remove-s3guard
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
