steveloughran commented on a change in pull request #3534:
URL: https://github.com/apache/hadoop/pull/3534#discussion_r782538228
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -4284,31 +3929,8 @@ private CopyResult copyFile(String srcKey, String
dstKey, long size,
String action = "copyFile(" + srcKey + ", " + dstKey + ")";
Invoker readInvoker = readContext.getReadInvoker();
- ObjectMetadata srcom;
- try {
- srcom = once(action, srcKey,
- () ->
- getObjectMetadata(srcKey, changeTracker, readInvoker, "copy"));
- } catch (FileNotFoundException e) {
- // if rename fails at this point it means that the expected file was not
- // found.
- // The cause is believed to always be one of
- // - File was deleted since LIST/S3Guard metastore.list.() knew of it.
- // - S3Guard is asking for a specific version and it's been removed by
- // lifecycle rules.
- // - there's a 404 cached in the S3 load balancers.
- LOG.debug("getObjectMetadata({}) failed to find an expected file",
- srcKey, e);
- // We create an exception, but the text depends on the S3Guard state
- String message = hasMetadataStore()
Review comment:
this is during a rename where the list call found the file, now we call
copy and it's not there.
the causes used to be
1. s3guard inconsistent
2. unguarded and 404 caching making the file not visible
3. something else deleted the file between list and copy
only #3 can happen now, so i was just leaving as it.
but I could revert, as we may want to differentiate the failure.
will revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
