[
https://issues.apache.org/jira/browse/HADOOP-11867?focusedWorklogId=707717&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-707717
]
ASF GitHub Bot logged work on HADOOP-11867:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jan/22 17:44
Start Date: 12/Jan/22 17:44
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#3499:
URL: https://github.com/apache/hadoop/pull/3499#discussion_r762152218
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/impl/TestVectoredReadUtils.java
##########
@@ -0,0 +1,315 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.impl;
+
+import org.apache.hadoop.fs.ByteBufferPositionedReadable;
+import org.apache.hadoop.fs.FileRange;
+import org.apache.hadoop.fs.FileRangeImpl;
+import org.apache.hadoop.fs.PositionedReadable;
+import org.junit.Test;
+
+import org.apache.hadoop.test.HadoopTestBase;
+import org.mockito.ArgumentMatchers;
+import org.mockito.Mockito;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.nio.IntBuffer;
+import java.util.Arrays;
+import java.util.List;
+import java.util.concurrent.CompletableFuture;
+import java.util.function.IntFunction;
+
+import org.assertj.core.api.Assertions;
+
+import static
org.apache.hadoop.test.MoreAsserts.assertFutureFailedExceptionaly;
+import static
org.apache.hadoop.test.MoreAsserts.assertFutureCompletedSuccessfully;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotSame;
+import static org.junit.Assert.assertSame;
+import static org.junit.Assert.assertTrue;
+
+/**
+ * Test behavior of {@link VectoredReadUtils}.
+ */
+public class TestVectoredReadUtils extends HadoopTestBase {
+
+ @Test
+ public void testSliceTo() {
+ final int SIZE = 64 * 1024;
+ ByteBuffer buffer = ByteBuffer.allocate(SIZE);
+ // fill the buffer with data
+ IntBuffer intBuffer = buffer.asIntBuffer();
+ for(int i=0; i < SIZE / Integer.BYTES; ++i) {
+ intBuffer.put(i);
+ }
+ // ensure we don't make unnecessary slices
+ ByteBuffer slice = VectoredReadUtils.sliceTo(buffer, 100,
+ new FileRangeImpl(100, SIZE));
+ Assertions.assertThat(buffer)
+ .describedAs("Slicing on the same offset shouldn't " +
+ "create a new buffer")
+ .isEqualTo(slice);
+
+ // try slicing a range
+ final int OFFSET = 100;
+ final int SLICE_START = 1024;
+ final int SLICE_LENGTH = 16 * 1024;
+ slice = VectoredReadUtils.sliceTo(buffer, OFFSET,
+ new FileRangeImpl(OFFSET + SLICE_START, SLICE_LENGTH));
+ // make sure they aren't the same, but use the same backing data
+ Assertions.assertThat(buffer)
+ .describedAs("Slicing on new offset should " +
+ "create a new buffer")
+ .isNotEqualTo(slice);
+ Assertions.assertThat(buffer.array())
+ .describedAs("Slicing should use the same underlying " +
+ "data")
+ .isEqualTo(slice.array());
+ // test the contents of the slice
+ intBuffer = slice.asIntBuffer();
+ for(int i=0; i < SLICE_LENGTH / Integer.BYTES; ++i) {
+ assertEquals("i = " + i, i + SLICE_START / Integer.BYTES,
intBuffer.get());
+ }
+ }
+
+ @Test
+ public void testRounding() {
+ for(int i=5; i < 10; ++i) {
+ assertEquals("i = "+ i, 5, VectoredReadUtils.roundDown(i, 5));
+ assertEquals("i = "+ i, 10, VectoredReadUtils.roundUp(i+1, 5));
+ }
+ assertEquals(13, VectoredReadUtils.roundDown(13, 1));
+ assertEquals(13, VectoredReadUtils.roundUp(13, 1));
+ }
+
+ @Test
+ public void testMerge() {
+ FileRange base = new FileRangeImpl(2000, 1000);
+ CombinedFileRange mergeBase = new CombinedFileRange(2000, 3000, base);
+
+ // test when the gap between is too big
+ assertFalse(mergeBase.merge(5000, 6000,
Review comment:
Can you add error message text to the true and false assertions?
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/impl/TestVectoredReadUtils.java
##########
@@ -0,0 +1,315 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.impl;
+
+import org.apache.hadoop.fs.ByteBufferPositionedReadable;
Review comment:
Nit: imports
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
##########
@@ -66,7 +74,7 @@
public static double getApproxChkSumLength(long size) {
return ChecksumFSOutputSummer.CHKSUM_AS_FRACTION * size;
}
-
+
Review comment:
These are all needless and making the patch a bit bigger than it should
be. was yetus complaining?
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/VectoredReadUtils.java
##########
@@ -0,0 +1,253 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.impl;
+
+import java.io.EOFException;
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Comparator;
+import java.util.List;
+import java.util.concurrent.CompletableFuture;
+import java.util.function.IntFunction;
+
+import org.apache.hadoop.fs.ByteBufferPositionedReadable;
+import org.apache.hadoop.fs.FileRange;
+import org.apache.hadoop.fs.PositionedReadable;
+import org.apache.hadoop.util.Preconditions;
+
+public class VectoredReadUtils {
Review comment:
Nit: javadocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 707717)
Time Spent: 9h 10m (was: 9h)
> FS API: Add a high-performance vectored Read to FSDataInputStream API
> ---------------------------------------------------------------------
>
> Key: HADOOP-11867
> URL: https://issues.apache.org/jira/browse/HADOOP-11867
> Project: Hadoop Common
> Issue Type: New Feature
> Components: fs, fs/azure, fs/s3, hdfs-client
> Affects Versions: 3.0.0
> Reporter: Gopal Vijayaraghavan
> Assignee: Mukund Thakur
> Priority: Major
> Labels: performance, pull-request-available
> Time Spent: 9h 10m
> Remaining Estimate: 0h
>
> The most significant way to read from a filesystem in an efficient way is to
> let the FileSystem implementation handle the seek behaviour underneath the
> API to be the most efficient as possible.
> A better approach to the seek problem is to provide a sequence of read
> locations as part of a single call, while letting the system schedule/plan
> the reads ahead of time.
> This is exceedingly useful for seek-heavy readers on HDFS, since this allows
> for potentially optimizing away the seek-gaps within the FSDataInputStream
> implementation.
> For seek+read systems with even more latency than locally-attached disks,
> something like a {{readFully(long[] offsets, ByteBuffer[] chunks)}} would
> take of the seeks internally while reading chunk.remaining() bytes into each
> chunk (which may be {{slice()}}ed off a bigger buffer).
> The base implementation can stub in this as a sequence of seeks + read() into
> ByteBuffers, without forcing each FS implementation to override this in any
> way.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
