[
https://issues.apache.org/jira/browse/HADOOP-17409?focusedWorklogId=708267&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-708267
]
ASF GitHub Bot logged work on HADOOP-17409:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jan/22 12:40
Start Date: 13/Jan/22 12:40
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#3534:
URL: https://github.com/apache/hadoop/pull/3534#discussion_r783920317
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -3821,23 +3481,14 @@ S3AFileStatus s3GetFileStatus(final Path path,
// by the time of listing so that the response includes some
// which have not.
- int listSize;
- if (tombstones == null) {
- // no tombstones so look for a marker and at least one child.
- listSize = 2;
- } else {
- // build a listing > tombstones. If the caller has many thousands
- // of tombstones this won't work properly, which is why pruning
- // of expired tombstones matters.
- listSize = Math.min(2 + tombstones.size(), Math.max(2, maxKeys));
- }
+ final int listSize = 2;
S3ListRequest request = createListObjectsRequest(dirKey, "/",
listSize);
// execute the request
S3ListResult listResult = listObjects(request,
getDurationTrackerFactory());
- if (listResult.hasPrefixesOrObjects(contextAccessors, tombstones)) {
+ if (listResult.hasPrefixesOrObjects(contextAccessors, null)) {
Review comment:
well spotted!
i've just gone through looking for all refs to *tombstone*
we can cut all the list reconciliation out, but also various test bits set
up to generate unique paths and so avoid tombstone problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 708267)
Time Spent: 11h 20m (was: 11h 10m)
> Remove S3Guard - no longer needed
> ---------------------------------
>
> Key: HADOOP-17409
> URL: https://issues.apache.org/jira/browse/HADOOP-17409
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/s3
> Affects Versions: 3.3.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Time Spent: 11h 20m
> Remaining Estimate: 0h
>
> With Consistent S3, S3Guard is superfluous.
> stop developing it and wean people off it as soon as they can.
> Then we can worry about what to do in the code. It has gradually insinuated
> its way through the layers, especially things like multi-object delete
> handling (see HADOOP-17244). Things would be a lot simpler without it
> This work is being done in the feature branch HADOOP-17409-remove-s3guard
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
