brumi1024 commented on a change in pull request #3763:
URL: https://github.com/apache/hadoop/pull/3763#discussion_r783960315
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestAHSv2ClientImpl.java
##########
@@ -22,7 +22,9 @@
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
+import com.google.common.collect.ImmutableMap;
import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.util.Time;
Review comment:
Nit: Was this imported by mistake?
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestAHSv2ClientImpl.java
##########
@@ -22,7 +22,9 @@
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
+import com.google.common.collect.ImmutableMap;
Review comment:
This should be shaded, please import
org.apache.hadoop.thirdparty.com.google.common.collect.ImmutableMap
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestAHSv2ClientImpl.java
##########
@@ -228,17 +304,17 @@ private static TimelineEntity
createContainerEntity(ContainerId containerId) {
entityInfo.put(ContainerMetricsConstants.ALLOCATED_MEMORY_INFO, 1024);
entityInfo.put(ContainerMetricsConstants.ALLOCATED_VCORE_INFO, 8);
entityInfo.put(ContainerMetricsConstants.ALLOCATED_HOST_INFO,
- "test host");
+ "test host");
entityInfo.put(ContainerMetricsConstants.ALLOCATED_PORT_INFO, 100);
entityInfo
- .put(ContainerMetricsConstants.ALLOCATED_PRIORITY_INFO, -1);
+ .put(ContainerMetricsConstants.ALLOCATED_PRIORITY_INFO, -1);
entityInfo.put(ContainerMetricsConstants
- .ALLOCATED_HOST_HTTP_ADDRESS_INFO, "http://test:1234";);
+ .ALLOCATED_HOST_HTTP_ADDRESS_INFO, "http://test:1234";);
entityInfo.put(ContainerMetricsConstants.DIAGNOSTICS_INFO,
- "test diagnostics info");
+ "test diagnostics info");
entityInfo.put(ContainerMetricsConstants.EXIT_STATUS_INFO, -1);
entityInfo.put(ContainerMetricsConstants.STATE_INFO,
- ContainerState.COMPLETE.toString());
+ ContainerState.COMPLETE.toString());
Review comment:
These seem to be unrelated, for the sake of easier backports/potential
conflicts please remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
