fapifta commented on pull request #3842: URL: https://github.com/apache/hadoop/pull/3842#issuecomment-1012369266
@jojochuang I did not have the time so far to thoroughly go through the linked paper, or test out the new code, but for the first sight, the option seems to be reasonable, and it seems to be added properly. For more extensive testing, I might have some time next week, but so far I can not promise it. Overall, the finding looks promising, and the implementation itself seems to be seamless with the related part of the code, so I am brave enough to say that I am fine with committing it. @cndaimin Can you share some details about your test results? I guess you have some measures with the implementation, is it something you can share? I would be curious what gains you can get with more threads, and if and where the gain is getting less and less when one adds more background threads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
