mukund-thakur commented on a change in pull request #3499:
URL: https://github.com/apache/hadoop/pull/3499#discussion_r786512204



##########
File path: 
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java
##########
@@ -955,11 +955,27 @@ private void populateBuffer(int length,
                               S3ObjectInputStream objectContent) throws 
IOException {
     if (buffer.isDirect()) {
       byte[] tmp = new byte[length];
-      objectContent.read(tmp, 0, length);
+      readByteArray(objectContent, tmp, 0, length);

Review comment:
       I made this change but then realised, the temp array will never be 
greater than maxReadSizeForVectorReads which is by default 1 MB. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to