wojiaodoubao commented on a change in pull request #3898:
URL: https://github.com/apache/hadoop/pull/3898#discussion_r788551958
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
##########
@@ -339,6 +339,13 @@ public boolean isFile() {
return false;
}
+ public boolean isSetStoragePolicy() {
Review comment:
A minor comment. It will be good if we add a comment to this method.
People may confuse about "inheriting storage policy from its parent" and
"containing storage policy itself". Add a comment like getStoragePolicyID() and
getLocalStoragePolicyID().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
