[ 
https://issues.apache.org/jira/browse/HADOOP-18093?focusedWorklogId=715319&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-715319
 ]

ASF GitHub Bot logged work on HADOOP-18093:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Jan/22 21:28
            Start Date: 25/Jan/22 21:28
    Worklog Time Spent: 10m 
      Work Description: hadoop-yetus commented on pull request #3931:
URL: https://github.com/apache/hadoop/pull/3931#issuecomment-1021625269


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 40s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
   |||| _ branch-3.2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  26m 48s |  |  branch-3.2 passed  |
   | +1 :green_heart: |  compile  |  15m  6s |  |  branch-3.2 passed  |
   | +1 :green_heart: |  checkstyle  |   0m 51s |  |  branch-3.2 passed  |
   | +1 :green_heart: |  mvnsite  |   1m 21s |  |  branch-3.2 passed  |
   | +1 :green_heart: |  javadoc  |   1m 14s |  |  branch-3.2 passed  |
   | +1 :green_heart: |  spotbugs  |   2m  7s |  |  branch-3.2 passed  |
   | +1 :green_heart: |  shadedclient  |  14m 52s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 50s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  14m 22s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |  14m 22s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 49s |  |  
hadoop-common-project/hadoop-common: The patch generated 0 new + 84 unchanged - 
1 fixed = 84 total (was 85)  |
   | +1 :green_heart: |  mvnsite  |   1m 21s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   1m 11s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   2m 19s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  15m  6s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | -1 :x: |  unit  |  15m 58s | 
[/patch-unit-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3931/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt)
 |  hadoop-common in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 51s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 115m 34s |  |  |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.fs.shell.TestCopyToLocal |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3931/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/3931 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell |
   | uname | Linux 1b28d37f4417 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | branch-3.2 / c10fbaf9a77745026f590a10c06e2efee62502e8 |
   | Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3931/1/testReport/ |
   | Max. process+thread count | 1276 (vs. ulimit of 5500) |
   | modules | C: hadoop-common-project/hadoop-common U: 
hadoop-common-project/hadoop-common |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3931/1/console |
   | versions | git=2.17.1 maven=3.6.0 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 715319)
    Time Spent: 2h 50m  (was: 2h 40m)

> Better exception handling for testFileStatusOnMountLink() in 
> ViewFsBaseTest.java
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-18093
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18093
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Xing Lin
>            Assignee: Xing Lin
>            Priority: Trivial
>              Labels: pull-request-available
>             Fix For: 3.4.0
>
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> The following exception handling code section in testFileStatusOnMountLink() 
>  
> {code:java}
>     try {
>       fcView.getFileStatus(new Path("/danglingLink"));
>       Assert.fail("Excepted a not found exception here");
>     } catch ( FileNotFoundException e) {
>       // as excepted
>     }{code}
> can be replaced with a single in the @Test 
> {code:java}
> @Test(expected = FileNotFoundException.class){code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to