[
https://issues.apache.org/jira/browse/HADOOP-18087?focusedWorklogId=715446&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-715446
]
ASF GitHub Bot logged work on HADOOP-18087:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/22 04:23
Start Date: 26/Jan/22 04:23
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3935:
URL: https://github.com/apache/hadoop/pull/3935#issuecomment-1021849158
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 57s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 35m 13s | | trunk passed |
| +1 :green_heart: | compile | 24m 15s | | trunk passed with JDK
Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 20m 26s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 0m 30s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 38s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 36s | | trunk passed with JDK
Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 0m 33s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 0m 54s | | trunk passed |
| +1 :green_heart: | shadedclient | 23m 18s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 20s | | the patch passed |
| +1 :green_heart: | compile | 23m 27s | | the patch passed with JDK
Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 23m 27s | | the patch passed |
| +1 :green_heart: | compile | 20m 34s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 20m 34s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 28s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 35s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 34s | | the patch passed with JDK
Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 0m 32s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 1m 2s | | the patch passed |
| +1 :green_heart: | shadedclient | 23m 29s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 1m 17s |
[/patch-unit-hadoop-common-project_hadoop-registry.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3935/1/artifact/out/patch-unit-hadoop-common-project_hadoop-registry.txt)
| hadoop-registry in the patch passed. |
| +1 :green_heart: | asflicense | 0m 48s | | The patch does not
generate ASF License warnings. |
| | | 183m 5s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.registry.server.dns.TestSecureRegistryDNS |
| | hadoop.registry.server.dns.TestRegistryDNS |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3935/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3935 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 142ffc858285 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5
11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / e20271e894a20a95a7988efb4c9db766e92c062a |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3935/1/testReport/ |
| Max. process+thread count | 520 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-registry U:
hadoop-common-project/hadoop-registry |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3935/1/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 715446)
Time Spent: 2h (was: 1h 50m)
> fix bug when getting CNAME chain records and no record from remote dns server
> -----------------------------------------------------------------------------
>
> Key: HADOOP-18087
> URL: https://issues.apache.org/jira/browse/HADOOP-18087
> Project: Hadoop Common
> Issue Type: Bug
> Components: registry
> Affects Versions: 3.1.2
> Reporter: YUBI LEE
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> When query A record which is chained by CNAME, YARN Registry DNS Server does
> not properly respond. Some CNAME records are missing.
> For example, "repo.maven.apache.org" is chaned as follows:
> repo.maven.apache.org. 21317 IN CNAME repo.apache.maven.org.
> repo.apache.maven.org. 20114 IN CNAME maven.map.fastly.net.
> maven.map.fastly.net. 7 IN A 199.232.192.215
> maven.map.fastly.net. 7 IN A 199.232.196.215
> If ask A record for "repo.maven.apache.org" using "dig" or "nslookup", YARN
> Registry DNS Server will give answers similar to this:
> (10.1.2.3, 10.8.8.8 IP is virtual)
> {code}
> $ nslookup repo.maven.apache.org 10.1.2.3
> Server: 10.1.2.3
> Address: 10.1.2.3#53
> Non-authoritative answer:
> repo.maven.apache.org canonical name = repo.apache.maven.org.
> Name: maven.map.fastly.net
> Address: 151.101.196.215
> ** server can't find repo.apache.maven.org: NXDOMAIN
> {code}
> The reason why you can see "NXDOMAIN", "nslookup" will query "A" & "AAAA"
> records.
> If there is no answer from other dns server, "answers == null" but YARN
> Registry DNS Server has a bug. There is no null handling.
> {code:java}
> // Forward lookup to primary DNS servers
> Record[] answers = getRecords(name, type);
> try {
> for (Record r : answers) {
> if (!response.findRecord(r)) {
> if (r.getType() == Type.SOA) {
> response.addRecord(r, Section.AUTHORITY);
> } else {
> response.addRecord(r, Section.ANSWER);
> }
> }
> if (r.getType() == Type.CNAME) {
> Name cname = r.getName();
> if (iterations < 6) {
> remoteLookup(response, cname, type, iterations + 1);
> }
> }
> }
> } catch (NullPointerException e) {
> return Rcode.NXDOMAIN;
> } catch (Throwable e) {
> return Rcode.SERVFAIL;
> }
> return Rcode.NOERROR;
> {code}
> It should be like this:
> {code}
> nslookup repo.maven.apache.org 10.8.8.8
> Server: 10.8.8.8
> Address: 10.8.8.8#53
> Non-authoritative answer:
> repo.maven.apache.org canonical name = repo.apache.maven.org.
> repo.apache.maven.org canonical name = maven.map.fastly.net.
> Name: maven.map.fastly.net
> Address: 151.101.196.215
> {code}
> I will make a pull request at https://github.com/apache/hadoop soon.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
