tomscut commented on a change in pull request #3827:
URL: https://github.com/apache/hadoop/pull/3827#discussion_r793191324
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeReconfiguration.java
##########
@@ -365,4 +372,79 @@ public void testBlockReportIntervalReconfiguration()
.getConf().get(DFS_BLOCKREPORT_INTERVAL_MSEC_KEY));
}
}
+
+ @Test
+ public void testSlowPeerParameters()
+ throws ReconfigurationException {
+ String[] slowPeersParameters = {
+ DFS_DATANODE_MIN_OUTLIER_DETECTION_NODES_KEY,
+ DFS_DATANODE_SLOWPEER_LOW_THRESHOLD_MS_KEY,
+ DFS_DATANODE_PEER_METRICS_MIN_OUTLIER_DETECTION_SAMPLES_KEY};
+
+ for (int i = 0; i < NUM_DATA_NODE; i++) {
+ DataNode dn = cluster.getDataNodes().get(i);
+
+ // Try invalid values.
+ try {
+ dn.reconfigureProperty(DFS_DATANODE_PEER_STATS_ENABLED_KEY, "text");
+ } catch (ReconfigurationException expected) {
+ assertEquals("Could not change property
dfs.datanode.peer.stats.enabled from 'true' to " +
+ "'text'", expected.getMessage());
+ }
Review comment:
Hi @ayushtkn , I update it, PTAL. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
