tomscut commented on pull request #3928:
URL: https://github.com/apache/hadoop/pull/3928#issuecomment-1024085323
> > ```
> > + if (!isBlockReplicatedOk(dn, b, false, null)) {
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > Hi @sodonnel , I just want to make sure that we don't have to take the
inverse here? Please point me out if I understand wrong.
> > ```
> > while(iterator.hasNext()) {
> > + BlockInfo b = iterator.next();
> > + if (isBlockReplicatedOk(dn, b, false, null)) {
> > + iterator.remove();
> > + }
> > + }
> > ```
>
> Yes you are correct, my suggested code has it wrong. We need to remove
from the list if it is replicated OK. The original code only added if it was
not replicated OK.
Thanks @sodonnel for your quick reply. I'll update the code and do some
related tests later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
