brumi1024 commented on a change in pull request #3946:
URL: https://github.com/apache/hadoop/pull/3946#discussion_r795761880
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/ParentQueue.java
##########
@@ -105,7 +106,7 @@
// leaf queue can use this to calculate effective resources.
// This field will not be edited, reference will point to a new immutable map
Review comment:
AFAIK this isn't true anymore.
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/ParentQueue.java
##########
@@ -1328,8 +1329,8 @@ private void
calculateEffectiveResourcesAndCapacity(String label,
}
}
- effectiveMinRatioPerResource = getEffectiveMinRatioPerResource(
- configuredMinResources, numeratorForMinRatio);
+ effectiveMinRatioPerResource.put(label, getEffectiveMinRatioPerResource(
Review comment:
Nit/idea: I think a name like effectiveMinResourceRatio is a bit more
descriptive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
