omalley commented on a change in pull request #3950:
URL: https://github.com/apache/hadoop/pull/3950#discussion_r796168022
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
##########
@@ -102,7 +102,7 @@ protected Path fullPath(final Path path) {
* @param uri base uri
* @throws IOException
*/
- ChRootedFileSystem(final FileSystem fs, URI uri) throws IOException {
+ public ChRootedFileSystem(final FileSystem fs, URI uri) throws IOException {
Review comment:
Why is this public instead of protected?
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
##########
@@ -102,7 +102,7 @@ protected Path fullPath(final Path path) {
* @param uri base uri
* @throws IOException
*/
- ChRootedFileSystem(final FileSystem fs, URI uri) throws IOException {
+ public ChRootedFileSystem(final FileSystem fs, URI uri) throws IOException {
Review comment:
The same applies to the rest of the private to public changes.
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/FsGetter.java
##########
@@ -20,15 +20,15 @@
import java.io.IOException;
import java.net.URI;
-import org.apache.hadoop.classification.InterfaceAudience.Private;
+import org.apache.hadoop.classification.InterfaceAudience;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.FileSystem;
/**
* File system instance getter.
*/
-@Private
-class FsGetter {
[email protected]
Review comment:
I'd be far happier with LimitedPrivate here. Certainly, you should also
add an Evolving annotation also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
