[
https://issues.apache.org/jira/browse/HADOOP-18046?focusedWorklogId=718426&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-718426
]
ASF GitHub Bot logged work on HADOOP-18046:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Feb/22 06:02
Start Date: 01/Feb/22 06:02
Worklog Time Spent: 10m
Work Description: functioner commented on pull request #3872:
URL: https://github.com/apache/hadoop/pull/3872#issuecomment-1026504948
@iwasakims @ayushtkn @steveloughran Thank you for your suggestions.
I inspected this test more carefully and I found that previous I wrote the
`testIOEOnListenerAccept` based on `doErrorTest`, which is generally used in
the scenario where the fault is about the data type (e.g., `IOEOnWriteWritable`
instead of `LongWritable`).
However, the scenario here is more similar to
`testRTEDuringConnectionSetup`, `testIpcTimeout`, `testIpcConnectTimeout`,
`testIpcWithServiceClass`, etc. I notice that these tests share some style
which is slightly different from `doErrorTest`. Specifically, they have `new
TestServer(1, true)` and make the client call with `call(client,
RANDOM.nextLong(), address, conf)` where `address` is
`NetUtils.getConnectAddress(server)`.
I try to enforce this style and it works on my local machine when I run `mvn
test -Dtest=TestIPC -Pparallel-tests`. On the contrary, without this
modification, `mvn test -Dtest=TestIPC -Pparallel-tests` may fail
`testIOEOnListenerAccept` in the way you guys reported.
I push this new commit and would like to see whether it works on our CI
servers and see potential new comments.
@iwasakims @ayushtkn PTAL. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 718426)
Time Spent: 1h 50m (was: 1h 40m)
> TestIPC#testIOEOnListenerAccept fails
> -------------------------------------
>
> Key: HADOOP-18046
> URL: https://issues.apache.org/jira/browse/HADOOP-18046
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Reporter: Akira Ajisaka
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> {code}
> [ERROR] testIOEOnListenerAccept(org.apache.hadoop.ipc.TestIPC) Time elapsed:
> 0.007 s <<< FAILURE!
> java.lang.AssertionError: Expected an EOFException to have been thrown
> at org.junit.Assert.fail(Assert.java:89)
> at
> org.apache.hadoop.ipc.TestIPC.testIOEOnListenerAccept(TestIPC.java:652)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
> at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
