9uapaw commented on a change in pull request #3470: URL: https://github.com/apache/hadoop/pull/3470#discussion_r797352341
########## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/ResourceCalculationDriver.java ########## @@ -0,0 +1,368 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity; + +import org.apache.commons.lang3.tuple.ImmutablePair; +import org.apache.commons.lang3.tuple.Pair; +import org.apache.hadoop.thirdparty.com.google.common.collect.ImmutableSet; +import org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.QueueCapacityVector.QueueCapacityVectorEntry; +import org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.QueueCapacityVector.ResourceUnitCapacityType; + +import java.util.Collection; +import java.util.HashMap; +import java.util.Map; +import java.util.Set; + +import static org.apache.hadoop.yarn.api.records.ResourceInformation.MEMORY_URI; + +/** + * Drives the main logic of resource calculation for all children under a parent queue. Acts as a + * bookkeeper of disposable update information that is used by all children under a common parent. + */ +public class ResourceCalculationDriver { + protected static final Set<ResourceUnitCapacityType> CALCULATOR_PRECEDENCE = + ImmutableSet.of( + ResourceUnitCapacityType.ABSOLUTE, + ResourceUnitCapacityType.PERCENTAGE, + ResourceUnitCapacityType.WEIGHT); + + protected final QueueResourceRoundingStrategy roundingStrategy = + new DefaultQueueResourceRoundingStrategy(CALCULATOR_PRECEDENCE); + protected final CSQueue parent; + protected final QueueCapacityUpdateContext updateContext; + protected final Map<ResourceUnitCapacityType, AbstractQueueCapacityCalculator> calculators; + protected final Collection<String> definedResources; + + protected final Map<String, ResourceVector> overallRemainingResource = new HashMap<>(); + protected final Map<String, ResourceVector> batchRemainingResource = new HashMap<>(); + // Used by ABSOLUTE capacity types + protected final Map<String, ResourceVector> normalizedResourceRatio = new HashMap<>(); + // Used by WEIGHT capacity typet js + protected final Map<String, Map<String, Float>> sumWeightsPerLabel = new HashMap<>(); + + protected String currentResourceName; + protected AbstractQueueCapacityCalculator currentCalculator; + protected CSQueue currentChild; Review comment: I agree, replaced it with a context object that is passed as argument. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
