omalley commented on a change in pull request #3956:
URL: https://github.com/apache/hadoop/pull/3956#discussion_r803961478
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
##########
@@ -1102,6 +1104,131 @@ public void testTrashRoot() throws IOException {
Assert.assertTrue("", fsView.getTrashRoots(true).size() > 0);
}
+ /**
Review comment:
Actually, it isn't. I was more concerned with what would happen with an
encryption zone or snapshot root. You'd need to make a mock child file system
that implements a custom getTrashRoot(path).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
