omalley commented on a change in pull request #3981:
URL: https://github.com/apache/hadoop/pull/3981#discussion_r808334779
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
##########
@@ -636,15 +630,19 @@ public boolean hasNext() throws IOException {
@Override
public LocatedFileStatus next() throws IOException {
final LocatedFileStatus status = statusIter.next();
- return (LocatedFileStatus)fixFileStatus(status,
- getChrootedPath(res, status, f));
+ return (LocatedFileStatus) fixFileStatus(status,
+ getChrootedPath(res, status, f), f, res.isInternalDir());
}
};
}
private Path getChrootedPath(InodeTree.ResolveResult<FileSystem> res,
FileStatus status, Path f) throws IOException {
final String suffix;
+ // For internal directories return the qualified path of status
Review comment:
What is this really doing? It looks like it was already handled as the
last case previously.
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
##########
@@ -517,8 +517,8 @@ public FileChecksum getFileChecksum(final Path f, final
long length)
return res.targetFileSystem.getFileChecksum(res.remainingPath, length);
}
- private static FileStatus fixFileStatus(FileStatus orig,
- Path qualified) throws IOException {
+ private static FileStatus fixFileStatus(FileStatus orig, Path qualifiedPath,
+ Path originalPath, boolean isInternalDir) throws IOException {
Review comment:
Why are you adding the originalPath and isInternalDir when they aren't
used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
