hfutatzhanghb commented on a change in pull request #3976:
URL: https://github.com/apache/hadoop/pull/3976#discussion_r808664831



##########
File path: 
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ObserverReadProxyProvider.java
##########
@@ -342,7 +342,7 @@ private synchronized void initializeMsync() throws 
IOException {
     if (msynced) {
       return; // No need for an msync
     }
-    getProxyAsClientProtocol(failoverProxy.getProxy().proxy).msync();

Review comment:
       hi, @ayushtkn , thanks a lot for replying.
   In class ObserverReadProxyProvider, there are two varaibles used to get 
NameNode proxy. One is failoverProxy, another is nameNodeProxies. For read 
requests,  it will use nameNodeProxies to get a proxy of observer namenode, but 
for msync rpc, it will use varaible failoverProxy to get an active namenode 
proxy. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to