9uapaw commented on a change in pull request #3938:
URL: https://github.com/apache/hadoop/pull/3938#discussion_r808897045
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacitySchedulerQueueManager.java
##########
@@ -635,6 +638,42 @@ public AbstractLeafQueue createQueue(QueuePath queue)
return parentsToCreate;
}
+ public List<Permission> getPermissionsForDynamicQueue(
+ QueuePath queuePath,
+ CapacitySchedulerConfiguration csConf) throws
SchedulerDynamicEditException {
+
+ List<Permission> permissions = new ArrayList<>();
+ PrivilegedEntity privilegedEntity =
getPrivilegedEntity(queuePath.getFullPath());
+
+ CSQueue parentQueue = getQueueByFullName(queuePath.getParent());
+ if (parentQueue == null) {
Review comment:
What I mean is that if parentQueue is not null, then
determineMissingParents will return with an empty list hopefully (if
parentQueue is not null, there are no missing parents, hence the empty list).
In this case, the iteration scope will not be executed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]