szilard-nemeth commented on a change in pull request #3763:
URL: https://github.com/apache/hadoop/pull/3763#discussion_r809384030
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AHSv2ClientImpl.java
##########
@@ -137,9 +137,7 @@ public ContainerReport getContainerReport(ContainerId
containerId)
ApplicationId appId = applicationAttemptId.getApplicationId();
ApplicationReport appReport = getApplicationReport(appId);
Map<String, String> filters = new HashMap<>();
- filters.put("infofilters", "SYSTEM_INFO_PARENT_ENTITY eq {\"id\":\"" +
- applicationAttemptId.toString() +
- "\",\"type\":\"YARN_APPLICATION_ATTEMPT\"}");
+ filters.put("appattemptId", applicationAttemptId.toString());
Review comment:
For me, this part seems suspicious. I'm not an expert in ATSv2 but I
don't see the reason what does "SYSTEM_INFO_PARENT_ENTITY eq something" mean
and why it would be easily replacable with "appattemptId".
If we figure this out from the code, I can proceed with the review.
Alternatively, we could try this out on a working cluster.
@brumi1024 What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
