bhalchandrap commented on pull request #3736: URL: https://github.com/apache/hadoop/pull/3736#issuecomment-1043710783
Hi Steve, Thanks for your earlier reviews. Take your time, I do not want to make your workload worse. I am happy to work with you using any process that you recommend. Let me know what your recommendations are and I will adopt them. On Thu, Feb 17, 2022 at 12:40 PM Steve Loughran ***@***.***> wrote: > I'm not deliberately ignoring you, just so overloaded with my own work > that I've not been able to review anything. > > we've put mukund's vectored IO patch into a feature branch with the idea > being we will still do the normal review process before every patch, but we > can get that short chain of patches lined up before the big merge into > trunk. we can also play rebase and interactive rebase too. > > would that work for you too? so patch 1 is "take what there is", patch 2+ > being the changes we want in before shipping > > the risk is always it gets forgotten, so we still need to push hard to get > it into a state where it can be used as an option, the goal being "no side > effects if not used", including nothing extra on the classpath. > > meanwhile, have a look at this #2584 > <https://github.com/apache/hadoop/pull/2584> > > its a big patch, but a key feature is you can declare your read policy, > with whole-file being an option as well as random, sequential and vectored. > > distcp and the CLI tools all declare their read plans this way > > i'd like this in before both the vectored io and your stream, so you can > use it to help decide whether to cache etc, and to support custom options > as well as parse the newly defined standard ones > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/hadoop/pull/3736#issuecomment-1043409450>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ATA7ZBSIKJCGWTVIQ4DS6LLU3VMNTANCNFSM5I7V2OJQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
