tomscut opened a new pull request #3998: URL: https://github.com/apache/hadoop/pull/3998
JIRA: [HDFS-16458](https://issues.apache.org/jira/browse/HDFS-16458). TestNameNodeReconfigure#verifySPSEnabled was compared with itself(`isSPSRunning`) at assertEquals. In addition, after an `internal SPS `has been removed, `spsService daemon` will not start within StoragePolicySatisfyManager. I think the relevant code can be removed to simplify the code. IMO, after reconfig SPS mode, we just need to confirm whether the mode is correct and whether spsManager is NULL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
