ibuenros commented on a change in pull request #3996:
URL: https://github.com/apache/hadoop/pull/3996#discussion_r810219824
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java
##########
@@ -294,11 +294,11 @@ void addLink(final String pathComponent, final
INodeLink<T> link)
*/
INodeLink(final String pathToNode, final UserGroupInformation aUgi,
Function<URI, T> createFileSystemMethod,
- final URI aTargetDirLink) {
+ final String aTargetDirLink) throws URISyntaxException {
super(pathToNode, aUgi);
targetFileSystem = null;
- targetDirLinkList = new URI[1];
- targetDirLinkList[0] = aTargetDirLink;
+ targetDirLinkList = new String[1];
+ targetDirLinkList[0] = new URI(aTargetDirLink).toString();
Review comment:
What is the purpose of creating a URI and converting back to string?
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
##########
@@ -216,19 +216,19 @@ public boolean equals(Object obj) {
/**
* Array of target FileSystem URIs.
*/
- private final URI[] targetFileSystemURIs;
+ private final String[] targetFileSystemPaths;
- MountPoint(Path srcPath, URI[] targetFs) {
+ MountPoint(Path srcPath, String[] targetFs) {
mountedOnPath = srcPath;
- targetFileSystemURIs = targetFs;
+ targetFileSystemPaths = targetFs;
}
public Path getMountedOnPath() {
return mountedOnPath;
}
- public URI[] getTargetFileSystemURIs() {
- return targetFileSystemURIs;
+ public String[] getTargetFileSystemPaths() {
Review comment:
This is a public method, can we keep the old signature? We can transform
from string to URI within the method itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
