tasanuma commented on a change in pull request #3828:
URL: https://github.com/apache/hadoop/pull/3828#discussion_r813467175
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java
##########
@@ -1356,10 +1358,21 @@ long getBlockReportIntervalMs() {
}
void setBlockReportIntervalMs(long intervalMs) {
- Preconditions.checkArgument(intervalMs > 0);
+ Preconditions.checkArgument(intervalMs > 0,
+ DFS_BLOCKREPORT_INTERVAL_MSEC_KEY + " should be larger than 0");
this.blockReportIntervalMs = intervalMs;
}
+ void setOutliersReportIntervalMs(long intervalMs) {
+ Preconditions.checkArgument(intervalMs > 0,
+ DFS_DATANODE_OUTLIERS_REPORT_INTERVAL_KEY + " should be larger than 0");
+ this.outliersReportIntervalMs = intervalMs;
+ }
+
+ long getOutliersReportIntervalMs() {
Review comment:
Please add VisibleForTesting.
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ProfilingFileIoEvents.java
##########
@@ -145,4 +137,24 @@ private DataNodeVolumeMetrics getVolumeMetrics(final
FsVolumeSpi volume) {
}
return null;
}
+
+ public void setSampleRangeMax(int fileIOSamplingPercentage) {
+ isEnabled = Util.isDiskStatsEnabled(fileIOSamplingPercentage);
+ if (fileIOSamplingPercentage > 100) {
+ LOG.warn(DFSConfigKeys
+ .DFS_DATANODE_FILEIO_PROFILING_SAMPLING_PERCENTAGE_KEY +
+ " value cannot be more than 100. Setting value to 100");
+ fileIOSamplingPercentage = 100;
+ }
+ sampleRangeMax = (int) ((double) fileIOSamplingPercentage / 100 *
+ Integer.MAX_VALUE);
+ }
+
+ public boolean getDiskStatsEnabled() {
Review comment:
You can remove this method since it isn't used anywhere. Or let's use it
in the unit test and add VisibleForTesting.
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ProfilingFileIoEvents.java
##########
@@ -145,4 +137,24 @@ private DataNodeVolumeMetrics getVolumeMetrics(final
FsVolumeSpi volume) {
}
return null;
}
+
+ public void setSampleRangeMax(int fileIOSamplingPercentage) {
+ isEnabled = Util.isDiskStatsEnabled(fileIOSamplingPercentage);
+ if (fileIOSamplingPercentage > 100) {
+ LOG.warn(DFSConfigKeys
+ .DFS_DATANODE_FILEIO_PROFILING_SAMPLING_PERCENTAGE_KEY +
+ " value cannot be more than 100. Setting value to 100");
+ fileIOSamplingPercentage = 100;
+ }
+ sampleRangeMax = (int) ((double) fileIOSamplingPercentage / 100 *
+ Integer.MAX_VALUE);
+ }
+
+ public boolean getDiskStatsEnabled() {
+ return isEnabled;
+ }
+
+ public int getSampleRangeMax() {
Review comment:
Please add VisibleForTesting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
