vnhive commented on a change in pull request #3966:
URL: https://github.com/apache/hadoop/pull/3966#discussion_r813516566
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestNettyRPC.java
##########
@@ -0,0 +1,1742 @@
+/**
Review comment:
You are correct, this is TestRPC with netty turned on. I noticed that
parameterizing the unit tests and running both netty and non-netty was causing
a lot of test failures. These failures just went away when we separated the
netty and non-netty tests.
I thought as a first step I will just duplicate the test in a separate file
and check whether things pass. This seems to work. A lot of the failures have
gone away.
In my next PR, I will eliminate the redundancy.
Sorry for the inconvenience. But please rest assure that the test code will
pretty much remain the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
