ayushtkn commented on a change in pull request #4028:
URL: https://github.com/apache/hadoop/pull/4028#discussion_r816685678
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/TestMiniJournalCluster.java
##########
@@ -52,4 +53,70 @@ public void testStartStop() throws IOException {
c.shutdown();
}
}
+
+ @Test
+ public void testStartStopWithPorts() throws IOException {
+ Configuration conf = new Configuration();
+
+ try {
+ new MiniJournalCluster.Builder(conf).setHttpPorts(8481).build();
+ fail("Should not reach here");
+ } catch (IllegalArgumentException e) {
+ assertEquals("Num of http ports (1) should match num of JournalNodes
(3)", e.getMessage());
+ }
+
+ try {
+ new MiniJournalCluster.Builder(conf).setRpcPorts(8481, 8482)
+ .build();
+ fail("Should not reach here");
+ } catch (IllegalArgumentException e) {
+ assertEquals("Num of rpc ports (2) should match num of JournalNodes
(3)", e.getMessage());
+ }
+
+ try {
+ new MiniJournalCluster.Builder(conf).setHttpPorts(800, 9000,
10000).setRpcPorts(8481)
+ .build();
+ fail("Should not reach here");
+ } catch (IllegalArgumentException e) {
+ assertEquals("Num of rpc ports (1) should match num of JournalNodes
(3)", e.getMessage());
+ }
+
+ try {
+ new MiniJournalCluster.Builder(conf).setHttpPorts(800, 9000, 1000, 2000)
+ .setRpcPorts(8481, 8482, 8483)
+ .build();
+ fail("Should not reach here");
+ } catch (IllegalArgumentException e) {
+ assertEquals("Num of http ports (4) should match num of JournalNodes
(3)", e.getMessage());
+ }
+
+ MiniJournalCluster miniJournalCluster =
+ new MiniJournalCluster.Builder(conf).setHttpPorts(8481, 8482, 8483)
+ .setRpcPorts(8491, 8492, 8493).build();
Review comment:
> hence this UT should not collide with any other UTs.
I have similar concerns, We are hard coding the ports here, this test can
fail in specific environments where these ports are already occupied. We have
seen such cases in past..
--> Just had a cursory look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
