tomscut commented on a change in pull request #4028:
URL: https://github.com/apache/hadoop/pull/4028#discussion_r817298583
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/TestMiniJournalCluster.java
##########
@@ -52,4 +59,82 @@ public void testStartStop() throws IOException {
c.shutdown();
}
}
+
+ @Test
+ public void testStartStopWithPorts() throws Exception {
+ Configuration conf = new Configuration();
+
+ LambdaTestUtils.intercept(
+ IllegalArgumentException.class,
+ "Num of http ports (1) should match num of JournalNodes (3)",
+ "MiniJournalCluster port validation failed",
+ () -> {
+ new MiniJournalCluster.Builder(conf).setHttpPorts(8481).build();
+ });
+
+ LambdaTestUtils.intercept(
+ IllegalArgumentException.class,
+ "Num of rpc ports (2) should match num of JournalNodes (3)",
+ "MiniJournalCluster port validation failed",
+ () -> {
+ new MiniJournalCluster.Builder(conf).setRpcPorts(8481, 8482).build();
+ });
+
+ LambdaTestUtils.intercept(
+ IllegalArgumentException.class,
+ "Num of rpc ports (1) should match num of JournalNodes (3)",
+ "MiniJournalCluster port validation failed",
+ () -> {
+ new MiniJournalCluster.Builder(conf).setHttpPorts(800, 9000,
10000).setRpcPorts(8481)
+ .build();
+ });
+
+ LambdaTestUtils.intercept(
+ IllegalArgumentException.class,
+ "Num of http ports (4) should match num of JournalNodes (3)",
+ "MiniJournalCluster port validation failed",
+ () -> {
+ new MiniJournalCluster.Builder(conf).setHttpPorts(800, 9000, 1000,
2000)
+ .setRpcPorts(8481, 8482, 8483).build();
+ });
+
+ final int[] httpPorts = new int[] { NetUtils.getFreeSocketPort(),
NetUtils.getFreeSocketPort(),
+ NetUtils.getFreeSocketPort() };
+ final int[] rpcPorts = new int[] { NetUtils.getFreeSocketPort(),
NetUtils.getFreeSocketPort(),
+ NetUtils.getFreeSocketPort() };
Review comment:
Thanks @ayushtkn for ping me and your advice.
`NetUtils.getFreeSocketPort()` returns the currently freeport, which may be
occupied if not immediately used.
If we set the port to 0, the system will automatically assign a free port
for us. Then we'll see which ports are actually being used and do assert. Is
that ok? As @virajjasani mentioned
[here](https://github.com/apache/hadoop/pull/4028#discussion_r816694773) .
Please point out if I understand wrong. Thanks. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
