[
https://issues.apache.org/jira/browse/HADOOP-18150?focusedWorklogId=735873&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735873
]
ASF GitHub Bot logged work on HADOOP-18150:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/22 11:16
Start Date: 03/Mar/22 11:16
Worklog Time Spent: 10m
Work Description: mukund-thakur commented on a change in pull request
#4044:
URL: https://github.com/apache/hadoop/pull/4044#discussion_r818556277
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/audit/ITestAuditManagerDisabled.java
##########
@@ -42,11 +43,12 @@ public ITestAuditManagerDisabled() {
public Configuration createConfiguration() {
Configuration conf = super.createConfiguration();
resetAuditOptions(conf);
+ conf.set(AUDIT_ENABLED, "false");
Review comment:
Use conf.setBoolean (...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 735873)
Time Spent: 40m (was: 0.5h)
> Fix ITestAuditManagerDisabled after S3A audit logging was enabled in
> HADOOP-18091
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-18150
> URL: https://issues.apache.org/jira/browse/HADOOP-18150
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/s3
> Affects Versions: 3.3.2
> Reporter: Mehakmeet Singh
> Assignee: Mehakmeet Singh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In HADOOP-18094, we disabled audit logging by default and introduced an IT
> which verifies that by default the audit logging is disabled. After
> HADOOP-18091, we switched the audit logging back on, but that test remained,
> which now fails since by default we have the audit logging enabled now.
> *StackTrace:*
> {noformat}
> java.lang.AssertionError:
> Expecting:
> <Service ActiveAuditManagerS3A in state ActiveAuditManagerS3A: STARTED,
> auditor=LoggingAuditor{ID='38e14ec9-3439-4b8f-a2f6-993514a2ee4a',
> headerEnabled=true, rejectOutOfSpan=false}}>
> to be an instance of:
> <org.apache.hadoop.fs.s3a.audit.impl.NoopAuditManagerS3A>
> but was instance of:
> <org.apache.hadoop.fs.s3a.audit.impl.ActiveAuditManagerS3A> at
> org.apache.hadoop.fs.s3a.audit.ITestAuditManagerDisabled.testAuditorDisabled(ITestAuditManagerDisabled.java:60)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
> at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
> at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.lang.Thread.run(Thread.java:748){noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
