virajjasani commented on pull request #4027:
URL: https://github.com/apache/hadoop/pull/4027#issuecomment-1058138750


   Thanks @aajisaka. Based on the ApplicationPlacementAllocatorFactory, it 
looks like the code has sufficient null check to handle missing property value:
   ```
       try {
         if (appPlacementAllocatorName == null) {
           policyClass = 
ApplicationSchedulingConfig.DEFAULT_APPLICATION_PLACEMENT_TYPE_CLASS;
         } else {
           policyClass = Class.forName(appPlacementAllocatorName);
         }
       } catch (ClassNotFoundException e) {
         policyClass = 
ApplicationSchedulingConfig.DEFAULT_APPLICATION_PLACEMENT_TYPE_CLASS;
       }
   ```
   
   Moreover, I just checked latest 5-6 configs that are added to 
`configurationPrefixToSkipCompare` in the UT and none are present in 
yarn-default.xml.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to