[
https://issues.apache.org/jira/browse/HADOOP-17526?focusedWorklogId=737254&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737254
]
ASF GitHub Bot logged work on HADOOP-17526:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Mar/22 16:14
Start Date: 06/Mar/22 16:14
Worklog Time Spent: 10m
Work Description: Apache9 opened a new pull request #4050:
URL: https://github.com/apache/hadoop/pull/4050
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
Use Slf4jRequestLog in HttpRequestLog, so we do not need to depend on actual
log appender implementations in code.
For keeping the rolling way the safe, I have to use DailyRollingFileAppender
but the DRFA in log4j1 does not support removing old files, so we loss the
ability of 'RetainDays'. Anyway, later after we upgrade to log4j2, we can add
this ability back.
### How was this patch tested?
Introduced a new UT. Better to deploy a hadoop cluster, enable request log
and check the output.
### For code changes:
- [X] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 737254)
Remaining Estimate: 0h
Time Spent: 10m
> Use Slf4jRequestLog for HttpRequestLog
> --------------------------------------
>
> Key: HADOOP-17526
> URL: https://issues.apache.org/jira/browse/HADOOP-17526
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Akira Ajisaka
> Assignee: Duo Zhang
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Now the log file name and retain days in HttpRequestLog is configured from
> log4j.properties. It can be configured from Configuration instead to drop the
> usage of log4j API.
> ==== Update ====
> Use jetty's Slf4jRequestLogWriter, we can remove the code dependency on log
> appenders.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
