9uapaw commented on a change in pull request #3895:
URL: https://github.com/apache/hadoop/pull/3895#discussion_r820534080
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java
##########
@@ -389,4 +384,22 @@ public static void updateTestDataAutomatically(String
configFilename, String act
Assert.fail("overwrite should not fail " + e.getMessage());
}
}
+
+ public static WebAppDescriptor createWebAppDescriptor() {
+ return new WebAppDescriptor.Builder(
+ "org.apache.hadoop.yarn.server.resourcemanager.webapp")
Review comment:
This looks like a volatile constant here. We could use package name of
the class here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
