[
https://issues.apache.org/jira/browse/HADOOP-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176977#comment-13176977
]
Harsh J commented on HADOOP-2739:
---------------------------------
+1 for making them final if there's no compatibility breakage.
What do you gain by subclassing though? FWIW, metadata support is also provided
for custom user tags already.
> SequenceFile and MapFile should either be subclassable or they should be
> declared final
> ---------------------------------------------------------------------------------------
>
> Key: HADOOP-2739
> URL: https://issues.apache.org/jira/browse/HADOOP-2739
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.16.0
> Reporter: Jim Kellerman
> Assignee: Jim Kellerman
> Priority: Minor
>
> Neither SequenceFile nor MapFile are currently subclassable as there are no
> accessor methods to their private members or member functions. Either
> protected accessor methods should be added or the member variables should be
> declared as protected instead of private.
> OR
> both SequenceFile and MapFile should be declared as final.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
