smarthanwang commented on pull request #4061: URL: https://github.com/apache/hadoop/pull/4061#issuecomment-1066274434
> Thanks @smarthanwang involve me here. It almost look good to me. Just one nit, it seems changes default value here, any consideration? Just suggest keep it if no any concerns. Thanks again. @Hexiaoqiao thanks for comment. When deleting a large directory, the deletion loop would continue for a long time, if we set the lock holding limit as 500ms, the rpcQueueTime of almost all rpc requests would increase to 500ms, it's too long for production cluster. So I think it's better to **set a smaller default value which is not much greater than the avgRpcQueueTime of our cluster.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
