jojochuang commented on a change in pull request #4064:
URL: https://github.com/apache/hadoop/pull/4064#discussion_r825574426
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
##########
@@ -2434,6 +2438,27 @@ String reconfigureSlowNodesParameters(final
DatanodeManager datanodeManager,
}
}
+ private String reconfigureBlockInvalidateLimit(final DatanodeManager
datanodeManager,
+ final String property, final String newVal) throws
ReconfigurationException {
+ namesystem.writeLock();
+ try {
+ if (newVal == null) {
+
datanodeManager.setBlockInvalidateLimit(DFSConfigKeys.DFS_BLOCK_INVALIDATE_LIMIT_DEFAULT);
+ return
String.valueOf(DFSConfigKeys.DFS_BLOCK_INVALIDATE_LIMIT_DEFAULT);
+ } else {
+ datanodeManager.setBlockInvalidateLimit(Integer.parseInt(newVal));
+ return String.valueOf(datanodeManager.getBlockInvalidateLimit());
+ }
Review comment:
perhaps we should log the message here instead of in the finally block,
because if it throws an exception here, it won't be reconfigured.
In addition, if newVal == null, the method returns
DFS_BLOCK_INVALIDATE_LIMIT_DEFAULT, not
datanodeManager.getBlockInvalidateLimit().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
