[ 
https://issues.apache.org/jira/browse/HADOOP-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177475#comment-13177475
 ] 

Todd Lipcon commented on HADOOP-7924:
-------------------------------------

- maybe we should rename FailoverController to ManualFailoverController? or 
even just ManualFailover? IMO "FailoverController" has always had a connotation 
of being some kind of daemon.
- in the preFailoverCheck, I'd expect us to support the case where "svc1" is 
down -- ie the admin has noticed the active crashed, and therefore wants to 
initiate failover to svc2. We should treat this the same as a failure in 
calling transitionToStandby - i.e fence and continue.
- {{svc1}} and {{svc2}} aren't very descriptive parameter names - maybe 
{{fromSvc}} and {{toSvc}} or {{oldActive}} and {{newActive}}? The javadoc in 
{{failover(...)}} is also incorrect here for {{svc2Name}}
- in {{FailoverFailedException}}, no need to duplicate the standard exception 
javadoc from its parent class
                
> 
FailoverController for client-based configuration
> --------------------------------------------------
>
>                 Key: HADOOP-7924
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7924
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ha
>    Affects Versions: HA Branch (HDFS-1623)
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hadoop-7924.txt
>
>
> Basic FailoverController to coordinate fail-over using a client-based config 
> (ie fail-over from NameNode x to NameNode y). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to