guptashailesh92 opened a new pull request #4093:
URL: https://github.com/apache/hadoop/pull/4093
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
In our setup, we are using Hive and Tez and using offline tez-ui mode, where
we copy the ATS events files to other place and start tez-ui. To keep the event
files small, we are using
fs-support-append = false, and creating a new file for writing the events.
We can see that, in this mode, file name contains
[suffix](https://github.com/apache/hadoop/blob/1d5650c4d0acf33f141d593762682b3603523104/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/FileSystemTimelineWriter.java#L382)
as timestamp.
But at the time of
[read](https://github.com/apache/hadoop/blob/1d5650c4d0acf33f141d593762682b3603523104/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage/src/main/java/org/apache/hadoop/yarn/server/timeline/EntityGroupFSTimelineStore.java#L844),
we are relying on the FS to provide correct file order. If that fails, we are
adding event out of order, leading to event being discarded, or incorrect
information.
Fix could be sorting of the file names, based on suffix if append mode is
not used.
sample file names:
summarylog-appattempt_1647348120288_0001_000001_460237
entitylog-timelineEntityGroupId_1647348120288_1_dag_1647348120288_0001_1_673147
### How was this patch tested?
1. Added conf `yarn.timeline-service.fs-support-append` to false.
2. Ran a job, which created small files for domain, entity and summary log.
3. Ran ATS by copying all the entity files to custom location, and checked
tez-ui with and without the change. Was able to see latest status of the task
correctly after the change.
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
