tasanuma commented on a change in pull request #3915:
URL: https://github.com/apache/hadoop/pull/3915#discussion_r832926344
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Namesystem.java
##########
@@ -63,4 +63,16 @@
* directories. Create them if not.
*/
void checkAndProvisionSnapshotTrashRoots();
+
+ /**
+ * Release read lock with operation name.
+ * @param opName
+ */
+ void readUnlock(String opName);
+
+ /**
+ * Release write lock with operation name.
+ * @param opName
+ */
+ void writeUnlock(String opName);
Review comment:
How about moving the new methods to RwLock since it has all lock-related
methods? Although RwLock is not `@InterfaceAudience.Private`, I think we can
add new methods there if the target version is 3.4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
