steveloughran commented on a change in pull request #4036:
URL: https://github.com/apache/hadoop/pull/4036#discussion_r835272119
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
##########
@@ -677,6 +683,31 @@ public static void unZip(InputStream inputStream, File
toDir)
}
}
+ public static Set<PosixFilePermission> permissionsFromMode(int mode) {
Review comment:
1. can you add some javadocs to say that these only deal with
user/group/other and not suid
2. can you make package scoped so it can be called in tests, but not by
applications (so we don't have to maintain consistent behaviour forever)
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
##########
@@ -677,6 +683,31 @@ public static void unZip(InputStream inputStream, File
toDir)
}
}
+ public static Set<PosixFilePermission> permissionsFromMode(int mode) {
+ EnumSet<PosixFilePermission> permissions =
+ EnumSet.noneOf(PosixFilePermission.class);
+ addPermissions(permissions, "OTHERS", (long) mode);
+ addPermissions(permissions, "GROUP", (long) mode >> 3);
+ addPermissions(permissions, "OWNER", (long) mode >> 6);
+ return permissions;
+ }
+
+ /** Assign the original permissions to the file */
Review comment:
1. add params to javadoc and staqte that only bottom 7 bits are used
2. make package private
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
##########
@@ -677,6 +683,31 @@ public static void unZip(InputStream inputStream, File
toDir)
}
}
+ public static Set<PosixFilePermission> permissionsFromMode(int mode) {
+ EnumSet<PosixFilePermission> permissions =
+ EnumSet.noneOf(PosixFilePermission.class);
+ addPermissions(permissions, "OTHERS", (long) mode);
+ addPermissions(permissions, "GROUP", (long) mode >> 3);
+ addPermissions(permissions, "OWNER", (long) mode >> 6);
+ return permissions;
+ }
+
+ /** Assign the original permissions to the file */
+ public static void addPermissions(
+ Set<PosixFilePermission> permissions,
+ String prefix,
+ Long mode) {
Review comment:
nit, should be int
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
