aajisaka commented on a change in pull request #4110:
URL: https://github.com/apache/hadoop/pull/4110#discussion_r836213083
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/monitor/capacity/AbstractPreemptableResourceCalculator.java
##########
@@ -252,47 +284,146 @@ protected void initIdealAssignment(Resource totGuarant,
/**
* Computes a normalizedGuaranteed capacity based on active queues.
*
- * @param clusterResource
- * the total amount of resources in the cluster
* @param queues
* the list of queues to consider
* @param ignoreGuar
* ignore guarantee.
*/
- private void resetCapacity(Resource clusterResource,
- Collection<TempQueuePerPartition> queues, boolean ignoreGuar) {
+ private void resetCapacity(Collection<TempQueuePerPartition> queues,
Review comment:
For testing, I think we can make this method static package-private and
add `@VisibleForTesting` annotation. That way we can call this method directly
from test class. Note that the package of the annotation must be
"org.apache.hadoop.thirdparty.com.google.common.annotations".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
