[
https://issues.apache.org/jira/browse/HADOOP-15566?focusedWorklogId=748732&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-748732
]
ASF GitHub Bot logged work on HADOOP-15566:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Mar/22 15:55
Start Date: 28/Mar/22 15:55
Worklog Time Spent: 10m
Work Description: kiran-maturi commented on pull request #3445:
URL: https://github.com/apache/hadoop/pull/3445#issuecomment-1080825440
> * wire marshalling in protobuf: efficiency and compatibility
My thought for having a map was, the trace_id, parent_id, trace_flags,
trace_state have fixed lengths the serialization and deserialization is still
in progress for binary format. It might be good to wait for sometime based on
this
https://w3c.github.io/trace-context-binary/.
> * what our story about dependencies are.
Currently we need the agent jar only at runtime and its shaded already. We
need to have in seperate path other than the common which will not be picked by
default (ex $HADOOP_HOME/share/hadoop/trace). probably somewhere outside the
common. Opentelemetry APIs are light . The agent jar will only be picked from
env when enabled.
# export OPENTELEMETRY_JAVAAGENT_PATH="$(find
$HADOOP_HOME/share/hadoop/tools/lib/ -name opentelemetry-javaagent*)"
> for dependencies we either embrace and mandate a new jar on the cp for iPC
(easiest in our code) or do some reflection games to downgrade if it is not on
the classpath. which, given telemetry isn't normally a critical feature, could
be justified.
I am not sure if we need this
> how much extra pain in terms of transient dependencies would it be for us
to always make the jar a dependency of hadoop common?
We can keep it common the whole size was close to 28MB and its shaded.
Please share your thoughts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 748732)
Time Spent: 11h 10m (was: 11h)
> Support OpenTelemetry
> ---------------------
>
> Key: HADOOP-15566
> URL: https://issues.apache.org/jira/browse/HADOOP-15566
> Project: Hadoop Common
> Issue Type: New Feature
> Components: metrics, tracing
> Affects Versions: 3.1.0
> Reporter: Todd Lipcon
> Assignee: Siyao Meng
> Priority: Major
> Labels: pull-request-available, security
> Attachments: HADOOP-15566-WIP.1.patch, HADOOP-15566.000.WIP.patch,
> OpenTelemetry Support Scope Doc v2.pdf, OpenTracing Support Scope Doc.pdf,
> Screen Shot 2018-06-29 at 11.59.16 AM.png, ss-trace-s3a.png
>
> Time Spent: 11h 10m
> Remaining Estimate: 0h
>
> The HTrace incubator project has voted to retire itself and won't be making
> further releases. The Hadoop project currently has various hooks with HTrace.
> It seems in some cases (eg HDFS-13702) these hooks have had measurable
> performance overhead. Given these two factors, I think we should consider
> removing the HTrace integration. If there is someone willing to do the work,
> replacing it with OpenTracing might be a better choice since there is an
> active community.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
