ayushtkn commented on code in PR #4138:
URL: https://github.com/apache/hadoop/pull/4138#discussion_r842732623
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java:
##########
@@ -2163,6 +2163,15 @@ BlockReconstructionWork scheduleReconstruction(BlockInfo
block,
return null;
}
+ // skip if source datanodes for reconstructing ec block are not enough
+ if (block.isStriped()) {
+ BlockInfoStriped stripedBlock = (BlockInfoStriped) block;
+ if (stripedBlock.getDataBlockNum() > srcNodes.length) {
Review Comment:
Had a very quick look.
Just thinking about a scenario with say RS-6-3-1024k, and we just write 1
mb, in that case the total number of blocks available will be 1 Datablock + 3
Parity. In that case BG itself will have total 4 Blocks. Will this code start
returning null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
