virajjasani opened a new pull request, #4152:
URL: https://github.com/apache/hadoop/pull/4152
### Description of PR
While running the build, realized that all replacer plugin executions run
only after "banned-illegal-imports" enforcer plugin.
For instance,
```
[INFO] --- maven-enforcer-plugin:3.0.0:enforce (banned-illegal-imports) @
hadoop-cloud-storage ---
[INFO]
[INFO] --- replacer:1.5.3:replace (replace-generated-sources) @
hadoop-cloud-storage ---
[INFO] Skipping
[INFO]
[INFO] --- replacer:1.5.3:replace (replace-sources) @ hadoop-cloud-storage
---
[INFO] Skipping
[INFO]
[INFO] --- replacer:1.5.3:replace (replace-guava) @ hadoop-cloud-storage ---
[INFO] Replacement run on 0 file.
[INFO]
```
Hence, if our source code uses com.google.common, `banned-illegal-imports`
will cause the build failure and replacer plugin would not even get executed.
We should remove it as it is only redundant execution step.
### How was this patch tested?
Local build
### For code changes:
- [X] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
