[
https://issues.apache.org/jira/browse/HADOOP-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179788#comment-13179788
]
Hadoop QA commented on HADOOP-7949:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12509374/hadoop-7949.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 5 warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.ipc.TestSaslRPC
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/495//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/495//console
This message is automatically generated.
> Server maxIdleTime is way too low
> ---------------------------------
>
> Key: HADOOP-7949
> URL: https://issues.apache.org/jira/browse/HADOOP-7949
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.21.0, 0.22.0, 0.23.0, 1.0.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-7949.txt
>
>
> HADOOP-2909 intended to set the server max idle time for a connection to
> twice the client value. ("The server-side max idle time should be greater
> than the client-side max idle time, for example, twice of the client-side max
> idle time.") This way when a server times out a connection it's due a crashed
> client and not an inactive client so we don't close client connections with
> outstanding requests (by setting 2x the client value on the server side the
> client should time out the connection first).
> Looks like there was a typo in the patch and it set the default value to
> 1/5th the client value, instead of the intended 2x.
> {noformat}
> hadoop2 (pre-HADOOP-4687)$ git reset --hard 6fa4597e
> hadoop2 (pre-HADOOP-4687)$ grep -r ipc.client.connection.maxidletime .
> ./src/core/org/apache/hadoop/ipc/Client.java:
> conf.getInt("ipc.client.connection.maxidletime", 10000); //10s
> ./src/core/org/apache/hadoop/ipc/Server.java: this.maxIdleTime =
> 2*conf.getInt("ipc.client.connection.maxidletime", 1000);
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
