Hexiaoqiao commented on code in PR #4148:
URL: https://github.com/apache/hadoop/pull/4148#discussion_r847921761
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##########
@@ -2466,11 +2466,12 @@ boolean setReplication(final String src, final short
replication)
logAuditEvent(false, operationName, src);
throw e;
}
- if (success) {
+ if (status == FSDirAttrOp.SetRepStatus.SUCCESS) {
getEditLog().logSync();
- logAuditEvent(true, operationName, src);
}
- return success;
+ logAuditEvent(status != FSDirAttrOp.SetRepStatus.INVALID,
Review Comment:
IMO, this does not changes the prior log except additional false log when
setReplication failed.
a. if status == FSDirAttrOp.SetRepStatus.SUCCESS, it logs a true since
`status != FSDirAttrOp.SetRepStatus.INVALID`;
b. if status == FSDirAttrOp.SetRepStatus.UNCHANGED, it also logs a true
which is same as before.
c. if status == FSDirAttrOp.SetRepStatus.INVALID, it logs a false which is
additional compare to before logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
