[
https://issues.apache.org/jira/browse/HADOOP-16202?focusedWorklogId=756381&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-756381
]
ASF GitHub Bot logged work on HADOOP-16202:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Apr/22 13:21
Start Date: 13/Apr/22 13:21
Worklog Time Spent: 10m
Work Description: dannycjones commented on code in PR #2584:
URL: https://github.com/apache/hadoop/pull/2584#discussion_r849475521
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/AbstractS3AMockTest.java:
##########
@@ -70,6 +70,10 @@ public Configuration createConfiguration() {
// use minimum multipart size for faster triggering
conf.setLong(Constants.MULTIPART_SIZE, MULTIPART_MIN_SIZE);
conf.setInt(Constants.S3A_BUCKET_PROBE, 1);
+ // this is so stream draining is always blocking, allowing
+ // assertions to be safely made without worrying
+ // about any race conditions
+ conf.setInt(ASYNC_DRAIN_THRESHOLD, 128_000);
Review Comment:
Only after posting this has it clicked - we just want to make sure any
assertions on the stream are completed after drain? Makes sense.
`Integer.MAX_VALUE` might make it more explicit - I was wondering the
significance of `128_000`.
Issue Time Tracking
-------------------
Worklog Id: (was: 756381)
Time Spent: 19.5h (was: 19h 20m)
> Enhance openFile() for better read performance against object stores
> ---------------------------------------------------------------------
>
> Key: HADOOP-16202
> URL: https://issues.apache.org/jira/browse/HADOOP-16202
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs, fs/s3, tools/distcp
> Affects Versions: 3.3.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Time Spent: 19.5h
> Remaining Estimate: 0h
>
> The {{openFile()}} builder API lets us add new options when reading a file
> Add an option {{"fs.s3a.open.option.length"}} which takes a long and allows
> the length of the file to be declared. If set, *no check for the existence of
> the file is issued when opening the file*
> Also: withFileStatus() to take any FileStatus implementation, rather than
> only S3AFileStatus -and not check that the path matches the path being
> opened. Needed to support viewFS-style wrapping and mounting.
> and Adopt where appropriate to stop clusters with S3A reads switched to
> random IO from killing download/localization
> * fs shell copyToLocal
> * distcp
> * IOUtils.copy
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
